Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_data_dirs not documented, deprecate git_data_dir #159

Closed
pgassmann opened this issue Sep 27, 2017 · 1 comment
Closed

git_data_dirs not documented, deprecate git_data_dir #159

pgassmann opened this issue Sep 27, 2017 · 1 comment
Labels
backwards-incompatible docs Improvements or additions to documentation

Comments

@pgassmann
Copy link

Gitlab 10 deprecates the old git_data_dir: parameter.
https://about.gitlab.com/2017/09/22/gitlab-10-0-released/#drop-support-of-legacy-git-storage-configuration
The new git_data_dirs: option was added to init.pp and the template as mentioned in #103 by @davidgubler but the documentation is missing.

Also using the old git_data_dir: parameter should be deprecated on puppet level.
@pgassmann
Copy link
Author

Currently both options are added if gitlab::git_data_dir: is set

https://github.com/vshn/puppet-gitlab/blob/aad0b7d7661e3fcf63de926df61a26cd526281af/manifests/config.pp#L20-L26

@juniorsysadmin juniorsysadmin added backwards-incompatible docs Improvements or additions to documentation labels Jan 29, 2018
This was referenced Mar 30, 2018
Closed
Closed
LongLiveCHIEF added a commit that referenced this issue Mar 31, 2018
@LongLiveCHIEF
removed git_data_dir and db:setup
d56addc 
- removed  and documented . Closes #159
- removed the automatic execution of  if
service_manage =true and postgresql hash has configs but enable is undef || present.
closes #35
@LongLiveCHIEF LongLiveCHIEF mentioned this issue Mar 31, 2018
Merged
LongLiveCHIEF added a commit that referenced this issue Mar 31, 2018
@LongLiveCHIEF
removed git_data_dir and db:setup
4e2f022 
- removed  and documented . Closes #159
- removed the automatic execution of  if
service_manage =true and postgresql hash has configs but enable is undef || present.
closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-incompatible docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgassmann @juniorsysadmin