Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working on RHEL7? #17

Closed
jantman opened this issue Jul 17, 2015 · 2 comments
Closed

Not working on RHEL7? #17

jantman opened this issue Jul 17, 2015 · 2 comments

Comments

@jantman
Copy link

jantman commented Jul 17, 2015

I'm having some issues with this module on RHEL (not CentOS, real RHEL).

This module defines the repo baseurl as https://packages.gitlab.com/gitlab/gitlab-ce/el/$releasever/$basearch

However, on real RHEL, that evaluates as https://packages.gitlab.com/gitlab/gitlab-ce/el/7Server/x86_64/, however https://packages.gitlab.com/gitlab/gitlab-ce/el/7Server/x86_64/repodata/repomd.xml is 404.

It seems to me that when calculating the repository URL on RedHat-based systems, the module should probably just use the OS major release in Puppet, instead of relying on $releasever in yum.
@tobru
Copy link
Contributor

tobru commented Jul 17, 2015

This is fixed in the next release: #14

@tobru tobru closed this as completed Jul 17, 2015
@jantman
Copy link
Author

jantman commented Jul 17, 2015

Oops, I'm sorry. I'll pull in master...

b4ldr added a commit to icann-dns/puppet-gitlab that referenced this issue Apr 3, 2018
@b4ldr
# This is a combination of 26 commits.
b0607f5 
# This is the 1st commit message:

.

# This is the commit message #2:

remove duplicate githooks

# This is the commit message #3:

Refactor cirunners

-

-

update

# This is the commit message #4:

add deprecation notice

# This is the commit message voxpupuli#5:

add travis secret for publishing module

# This is the commit message voxpupuli#6:

release 1.16.0

# This is the commit message voxpupuli#7:

rename changelog for release gem

# This is the commit message voxpupuli#8:

rewrite changelog with github-changelog-generator

# This is the commit message voxpupuli#9:

[blacksmith] Bump version to 1.16.1-rc0

# This is the commit message voxpupuli#10:

modulesync 1.7.0

# This is the commit message voxpupuli#11:

modulesync 1.7.0 take 2

# This is the commit message voxpupuli#12:

fix spec test hiera location

# This is the commit message voxpupuli#13:

release 1.16.1

# This is the commit message voxpupuli#14:

[blacksmith] Bump version to 1.16.2-rc0

# This is the commit message voxpupuli#15:

Propose small spelling change

# This is the commit message voxpupuli#16:

Fixed redhat installation
# This is the commit message voxpupuli#17:

add letsencrypt section to gitlab.rb

# This is the commit message voxpupuli#18:

I think there were some minor problems with voxpupuli#155.  This allows managing the backup cron w/o managing the config file and fixing SKIP syntax.

# This is the commit message voxpupuli#19:

setup fast indexing of ssh keys

# This is the commit message voxpupuli#20:

add unit test for store_git_keys_in_db

# This is the commit message voxpupuli#21:

added docs for using store_git_keys_in_db feature

# This is the commit message voxpupuli#22:

add variable to scope

# This is the commit message voxpupuli#23:

update regex in ssh fast lookup spec

# This is the commit message voxpupuli#24:

another stab at regex

# This is the commit message voxpupuli#25:

typo correction

# This is the commit message voxpupuli#26:

checking file exists first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jantman @tobru