Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Would this module work with puppet 3.6.2? #20

Closed
ghost opened this issue Jul 21, 2015 · 2 comments
Closed

Question: Would this module work with puppet 3.6.2? #20

ghost opened this issue Jul 21, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 21, 2015

We were running spuder's gitlab module, and really want to leap to this module, but we are running puppet enterprise 3.6.2. Upgrading is on the roadmap, but not in the immediate future. Is it possible that the module is compatible with 3.6.2, but untested? Or did you use some 3.7-specific functionality (which is what I'm guessing).
@tobru
Copy link
Contributor

tobru commented Jul 21, 2015

Just give it a try, I'm not really sure if it runs on older versions than 3.7, but maybe it does.
Would be nice to have a feedback from you, also if it runs (so I can adjust the version requirements). If it doesn't run, we can try to get it working, just put the error message into this issue.

@spielkind
Copy link

Currently it seems that at least puppet 3.7 is required due to this bug:
https://tickets.puppetlabs.com/browse/PUP-1597

A workaround would be to change the init.pp (contain ::gitlab...) code.

diff --git a/manifests/init.pp b/manifests/init.pp
index d266237..3fe823c 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -247,8 +247,8 @@ class gitlab (
   class { '::gitlab::config': } ~>
   class { '::gitlab::service': }

-  contain ::gitlab::install
-  contain ::gitlab::config
-  contain ::gitlab::service
+  contain gitlab::install
+  contain gitlab::config
+  contain gitlab::service

 }

I would appreciate it to support the default puppet version of Ubuntu 14.04 (3.4.3).

@spielkind spielkind mentioned this issue Aug 12, 2015
Closed
tobru added a commit that referenced this issue Aug 27, 2015
@tobru
make init.pp more compatible with older Puppet versions. refs #20
cf0379a
@tobru tobru closed this as completed Aug 27, 2015
b4ldr added a commit to icann-dns/puppet-gitlab that referenced this issue Apr 3, 2018
@b4ldr
# This is a combination of 26 commits.
b0607f5 
# This is the 1st commit message:

.

# This is the commit message #2:

remove duplicate githooks

# This is the commit message #3:

Refactor cirunners

-

-

update

# This is the commit message #4:

add deprecation notice

# This is the commit message #5:

add travis secret for publishing module

# This is the commit message #6:

release 1.16.0

# This is the commit message #7:

rename changelog for release gem

# This is the commit message voxpupuli#8:

rewrite changelog with github-changelog-generator

# This is the commit message voxpupuli#9:

[blacksmith] Bump version to 1.16.1-rc0

# This is the commit message voxpupuli#10:

modulesync 1.7.0

# This is the commit message voxpupuli#11:

modulesync 1.7.0 take 2

# This is the commit message voxpupuli#12:

fix spec test hiera location

# This is the commit message voxpupuli#13:

release 1.16.1

# This is the commit message voxpupuli#14:

[blacksmith] Bump version to 1.16.2-rc0

# This is the commit message voxpupuli#15:

Propose small spelling change

# This is the commit message voxpupuli#16:

Fixed redhat installation
# This is the commit message voxpupuli#17:

add letsencrypt section to gitlab.rb

# This is the commit message voxpupuli#18:

I think there were some minor problems with voxpupuli#155.  This allows managing the backup cron w/o managing the config file and fixing SKIP syntax.

# This is the commit message voxpupuli#19:

setup fast indexing of ssh keys

# This is the commit message voxpupuli#20:

add unit test for store_git_keys_in_db

# This is the commit message voxpupuli#21:

added docs for using store_git_keys_in_db feature

# This is the commit message voxpupuli#22:

add variable to scope

# This is the commit message voxpupuli#23:

update regex in ssh fast lookup spec

# This is the commit message voxpupuli#24:

another stab at regex

# This is the commit message voxpupuli#25:

typo correction

# This is the commit message voxpupuli#26:

checking file exists first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better support for older puppet versions, see PUP-1597 spielkind/puppet-gitlab
2 participants
@tobru @spielkind