Backup cron configuration will trigger gitlab restart

[baurmatt]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: Every
• Ruby: Every
• Distribution: Every
• Module version: Current Master

How to reproduce (e.g Puppet code you use)

Change any backup_cron_* paramerters configuration

What are you seeing

Changes on backup cron will restart Gitlab

What behaviour did you expect instead

Changes on backup cron shouldn't restart Gitlab - only changes which are directly connected to the gitlab service should restart it

Output log

Any additional information you'd like to impart

[baurmatt]

I see to options:

• Removing the ~> in init.pp and replacing it with a notify => Class['gitlab::service'] for each resource in gitlab::config which needs it.
• Move backup into a separate class

I happily implement it, just tell me which you prefer.

[LongLiveCHIEF]

For now, let's move the the backup cron into it's own manifest.

In the long run, I think any configuration which affects the service should ideally wind up in the service.pp manifest, and any other configs get their own manifests, and the config.pp manifest at that point simply becomes an anchoring and ordering manifests using resource collectors if needed to control timing of specific configs.

This would work similarly to how the puppet/docker module config and service manifests are designed.

m also looking working on an option to manage backups as a systemd service using timers instead of CRON, and allowing implementors to choose which is preferred. Moving the backup into it's own manifest will make that PR easier as well.

Thanks @baurmatt I'll keep an eye out for this PR. Do you think it will be soon? I'm in the process of dropping a new release, and this is something I'd wait 24 hours to make sure it gets included.

[baurmatt]

on it :)