Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$web_server documentation differs from code #217

Closed
NiklausHofer opened this issue Apr 13, 2018 · 1 comment · Fixed by #219
Closed

$web_server documentation differs from code #217

NiklausHofer opened this issue Apr 13, 2018 · 1 comment · Fixed by #219
Labels
bug Something isn't working

Comments

@NiklausHofer
Copy link

# [*web_server*]
# Default: undef
# Hash of 'web_server' config parameters.

Optional[String] $web_server = undef,

web_server used to be of type hash, but now it is of type String. However, according to the documentation, it still is of type hash. So either the code or the documentation should be updated. I assume, that is is actually a bug in the code that appeared in commit 3fa7b17

Same is also true for the user parameter.

NiklausHofer pushed a commit to stepping-stone/puppet-gitlab that referenced this issue Apr 16, 2018
@juniorsysadmin juniorsysadmin added the bug Something isn't working label Apr 17, 2018
@benaryorg
Copy link

Especially since they've been validated as Hashes before anyway:

if $user { validate_hash($user) }
if $web_server { validate_hash($web_server) }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants