skip-auto-migrations should be placed before gitlab::install

[baurmatt]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: all
• Ruby: all
• Distribution: all
• Module version: current master

How to reproduce (e.g Puppet code you use)

• include gitlab
• puppet agent --test

class { 'gitlab':
  skip_auto_migrations => true,
}

• puppet agent --test

What are you seeing

The /etc/gitlab/skip-auto-migrations file is placed after the package was upgraded.

What behaviour did you expect instead

The /etc/gitlab/skip-auto-migrations file is placed before the package is upgraded

Output log

...
Notice: /Stage[main]/Gitlab::Install/Apt::Pin[hold-gitlab]/Apt::Setting[pref-hold-gitlab]/File[/etc/apt/preferences.d/hold-gitlab.pref]/content:
--- /etc/apt/preferences.d/hold-gitlab.pref	2018-04-27 15:31:22.471037747 +0200
+++ /tmp/puppet-file20180522-19558-1d6l1nk	2018-05-22 16:17:49.828120498 +0200
@@ -1,5 +1,5 @@
 # This file is managed by Puppet. DO NOT EDIT.
 Explanation: gitlab: hold-gitlab
 Package: gitlab-ce
-Pin: version 10.7.1-ce.0
+Pin: version 10.7.4-ce.0
 Pin-Priority: 1001

Info: Computing checksum on file /etc/apt/preferences.d/hold-gitlab.pref
Info: /Stage[main]/Gitlab::Install/Apt::Pin[hold-gitlab]/Apt::Setting[pref-hold-gitlab]/File[/etc/apt/preferences.d/hold-gitlab.pref]: Filebucketed /etc/apt/preferences.d/hold-gitlab.pref to puppet with sum 8f80062211f9ab2287fabd08255c0e3d
Notice: /Stage[main]/Gitlab::Install/Apt::Pin[hold-gitlab]/Apt::Setting[pref-hold-gitlab]/File[/etc/apt/preferences.d/hold-gitlab.pref]/content: content changed '{md5}8f80062211f9ab2287fabd08255c0e3d' to '{md5}fdc2be425403bff672950b90aa2eabd0'
Notice: /Stage[main]/Gitlab::Install/Package[gitlab-ce]/ensure: ensure changed '10.7.1-ce.0' to '10.7.4-ce.0'
...
Notice: /Stage[main]/Gitlab::Config/File[/etc/gitlab/skip-auto-migrations]/ensure: created

Any additional information you'd like to impart

[LongLiveCHIEF]

Good catch. I'll make sure to update this today with my PR for #228.

[LongLiveCHIEF]

btw, we'll also be deprecating in skip_auto_migrations in favor of skip_auto_reconfigure. I'm updating my branch with both the fix for this issue, as well as a deprecation handling for that variable. Just be on the lookout for that if you skip minor versions of this module since it would be a breaking change.

[baurmatt]

Sure, thanks for the heads up and fix! :)