-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zero-downtime updates #239
Milestone
Comments
LongLiveCHIEF
added a commit
to LongLiveCHIEF/puppet-gitlab
that referenced
this issue
Jun 2, 2018
- moved host_config to front - moved omnibus_config in front of install - closes voxpupuli#240 - made service a non-subscribe in init.pp ordering - required for voxpupuli#239
LongLiveCHIEF
added a commit
to LongLiveCHIEF/puppet-gitlab
that referenced
this issue
Jun 2, 2018
- moved host_config to front - moved omnibus_config in front of install - closes voxpupuli#240 - made service a non-subscribe in init.pp ordering - required for voxpupuli#239 closes voxpupuli#237
|
If you run Gitlab in a single server setup, you do not have a "deploy node" but you might need |
|
Yeah, that's why I worded it the way I did (not mentioning HA specifically). It's labeled with the HA Support Milestone merely because we can't really claim this module supports HA fully until this feature works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Whenever a node is utilized as a deploy node, the
gitlab-ctl reconfigurecommand should be run with an env ofSKIP_POST_DEPLOYMENT_MIGRATIONS=true. This shouldn't be a permanent env variable, for the node, so it makes sense to add a conditional to theExec['gitlab_reconfigurethat sets theenv =>attribute whenever a node is identified by adeploy_nodebooleanvariable for the module.Additionally, the
Service['gitlab-runsvdir']service is not designed to be restarted, and thus should not subscribe to config/package changes unless the implementor explicitly has a reason to do so.gitlab-runsvdiris a supervisor for the bundle of gitlab services on the host, andgitlab-ctl reconfigurerefreshes these services depending on the configs that changed.If puppet sends a refresh signal to the service, it will cause gitlab services to shut down, and make it impossible to do zero downtime updates.
Zero Downtime Updates Doc: https://docs.gitlab.com/omnibus/update/README.html#zero-downtime-updates`
The text was updated successfully, but these errors were encountered: