Change docker dependency

[minorOffense]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: all
• Ruby: all
• Distribution: all
• Module version: all

How to reproduce (e.g Puppet code you use)

Right now the ci runner install depends on gaether docker. Maybe should consider using the module provided by puppetlabs https://forge.puppet.com/puppetlabs/docker

What are you seeing

Using garethr/docker

What behaviour did you expect instead

Use https://forge.puppet.com/puppetlabs/docker

Output log

Any additional information you'd like to impart

Since the https://forge.puppet.com/puppetlabs/docker seems to be the more popular and supported option (garethr hasn’t seen an update in a while) and both modules seem really similarly setup should probably use the puppetlabs one. Or maybe both for backwards compatibility. The syntax is suspiciously similar for both modules. I’m trying to see if I’m fact puppetlabs used garethr as a base or if they took it over. I don’t know yet.

[minorOffense]

Yeah they forked it.

puppetlabs/puppetlabs-docker@790d08e

[LongLiveCHIEF]

It doesn't really depend on specifically the garethr-docker module, it just depends on a docker module existing on your basemodulepath.

You can install either, and it will work as intended. As long as you have a docker class on the basemodulepath (with the right supported params) this module will compile. For example, I currently install hackerhappyhour-docker instead of puppetlabs-docker.

We do need to update the docs on this though to reference the new official upstream.

[minorOffense]

Ok great thanks for the info.