Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean flags to gitlab-runner cannot be passed #260

Closed
jessereynolds opened this issue Aug 7, 2018 · 2 comments
Closed

Boolean flags to gitlab-runner cannot be passed #260

jessereynolds opened this issue Aug 7, 2018 · 2 comments

Comments

@jessereynolds
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: any
  • Ruby: any
  • Distribution: any
  • Module version: 2.1.0

How to reproduce (e.g Puppet code you use)

Hiera data for a node:

gitlab_ci_runners:
  docker_puppet:
    url: 'https://gitlab.example/'
    registration-token: xxxxxxxx
    executor: docker
    docker-image: ruby:2.5
    tag-list: "puppet"
    run-untagged: true

What are you seeing

The --run-untagged option is passed to gitlab-runner register with a value of true

What behaviour did you expect instead

The --run-untagged option should be passed without a value as it does not take one.

Suggestion

Perhaps a set of boolean flags could be passed in a specifically named key in the config hash such as boolean_flags

@LongLiveCHIEF
Copy link
Contributor

Can you please re-open this in https://github.com/voxpupuli/puppet-gitlab_ci_runner? This functionality is being moved out into its own module.

Thanks!

@mojibake-umd
Copy link

For others having issues I have found the following to work (Still using puppet/gitlab 2.1.0) in hiera.
gitlab_ci_runners_defaults:
tag-list: 'executor-docker'
run-untagged=true: ' '
....blah blah blah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants