Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module has no parameter named external_url puppet error #330

Closed
brian-lamb-software-engineer opened this issue Mar 17, 2020 · 3 comments
Closed
Labels
needs-feedback Further information is requested

Comments

@brian-lamb-software-engineer
Copy link

brian-lamb-software-engineer commented Mar 17, 2020

affects Puppet PE 2018 LTS

Am i doing something wrong here? not sure why its not picking up this param.

mod 'puppet-gitlab', '4.0.1'

1 class profile::gitlab (
  2                                                                                                                                                            |
  3   #should puppet manage the config?  (default is false)                                                                                                    |
  4   Boolean $config_manage = false,                                                                                                                          |
  5                                                                                                                                                            |
  6   # using Hiera, or console param, pass in the full domain name for the site                                                                               |
  7   #String $external_url = "https://${::fqdn}",                                                                                                             |
  8   $external_url = undef,                                                                                                                                   |
  9                                                                                                                                                            |
 10   # pass in the edition, if you want enterprise use `ee` `cc` or `disabled`                                                                                |
 11   String $manage_upstream_edition = 'ce',                                                                                                                  |
 12                                                                                                                                                            |
 13   # this is intended to keep gitlab auto updated                                                                                                           |
 14   String $package_ensure = 'latest',                                                                                                                       |
 15                                                                                                                                                            |
 16   # run service on boot                                                                                                                                    |
 17   Boolean $service_enable = true,                                                                                                                          |
 18                                                                                                                                                            |
 19   # should puppet run the service (stopped, false, running (default), or true)                                                                             |
 20   Enum['stopped', 'false', 'running', 'true'] $service_ensure = 'running',                                                                                 |
 21                                                                                                                                                            |
 22 ) {                                                                                                                                                        |
 23   class { '::gitlab':                                                                                                                                      |
 24     config_manage  => $config_manage,                                                                                                                      |
 25     edition        => $edition,                                                                                                                            |
 26     externaL_url   => $external_url,                                                                                                                       |
 27     package_ensure => $package_ensure,                                                                                                                     |
 28     service_enable => $service_enable,                                                                                                                     |
 29     service_ensure => $service_ensure,                                                                                                                     |
 30   }                                                                                                                                                        |
 31 }

What are you seeing

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Class[Gitlab]: has no parameter named 'externaL_url'

What behaviour did you expect instead

for puppet agent to successfully run and external_url to be controlled via puppet, and automatically added to the configuration.

@saz
Copy link

saz commented Mar 20, 2020

It's external_url not externaL_url (note the uppercase L in external)

@dhoppe dhoppe added the needs-feedback Further information is requested label Mar 30, 2020
@brian-lamb-software-engineer
Copy link
Author

brian-lamb-software-engineer commented Apr 2, 2020

Oh, a sneaky typo, thanks. Ill let you know if that was actually the issue when i get back into that piece of code. Sure looks like it with the error reporting there. Thanks.

@baurmatt
Copy link
Contributor

baurmatt commented Apr 9, 2020

As this was clearly a typo I'm going to close this issue.

@baurmatt baurmatt closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants