Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx still not documented #371

Closed
tquid opened this issue Dec 8, 2020 · 3 comments
Closed

nginx still not documented #371

tquid opened this issue Dec 8, 2020 · 3 comments

Comments

@tquid
Copy link

tquid commented Dec 8, 2020

Although there was an issue from 2016 and a merged pull request regarding nginx configuration documentation, that pull request leads to something about the version of apt being used. The documentation still reads as [fixme]. Can we get this documented?
@kenyon
Copy link
Member

kenyon commented Dec 8, 2020

You mean something besides this? https://github.com/voxpupuli/puppet-gitlab#nginx-configuration

@tquid
Copy link
Author

tquid commented Dec 8, 2020

Yes, in addition to that. Note this part:

Details on available configuration options are available at [Fixme][NGINX settings].

@kenyon
Copy link
Member

kenyon commented Dec 9, 2020

Yes, in addition to that. Note this part:

Details on available configuration options are available at [Fixme][NGINX settings].

@tquid I see. If you are able to provide any enhancement to the documentation, we would gladly accept it! Thanks.

@antondollmaier antondollmaier mentioned this issue Mar 9, 2021
Merged
@kenyon kenyon closed this as completed in 18c3812 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenyon @tquid