Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with Puppet 4.5.3 and Rspec-Puppet #85

Closed
tobru opened this issue Aug 10, 2016 · 2 comments
Closed

Issues with Puppet 4.5.3 and Rspec-Puppet #85

tobru opened this issue Aug 10, 2016 · 2 comments
Labels
bug Something isn't working

Comments

@tobru
Copy link
Contributor

tobru commented Aug 10, 2016

Some strange issues with Puppet 4.5.3 and Rspec-Puppet:

Failures:

  1) gitlab supported operating systems gitlab class without any parameters on Debian (Jessie) should contain Class[gitlab::install] that comes before gitlab::config

     Failure/Error: it { is_expected.to contain_class('gitlab::install').that_comes_before('gitlab::config') }



     ArgumentError:

       No title provided and "gitlab::config" is not a valid resource reference

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:544:in `extract_type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:529:in `type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource/catalog.rb:353:in `resource'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:204:in `block in check_befores'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:203:in `each'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:203:in `check_befores'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:99:in `matches?'

     # ./spec/classes/init_spec.rb:17:in `block (4 levels) in <top (required)>'

  2) gitlab supported operating systems gitlab class without any parameters on Debian (Jessie) should contain Class[gitlab::service] that subscribes to gitlab::config

     Failure/Error: it { is_expected.to contain_class('gitlab::service').that_subscribes_to('gitlab::config') }



     ArgumentError:

       No title provided and "gitlab::config" is not a valid resource reference

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:544:in `extract_type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:529:in `type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource/catalog.rb:353:in `resource'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:228:in `block in check_subscribes'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:227:in `each'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:227:in `check_subscribes'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:102:in `matches?'

     # ./spec/classes/init_spec.rb:19:in `block (4 levels) in <top (required)>'

  3) gitlab supported operating systems gitlab class without any parameters on RedHat (CentOS) should contain Class[gitlab::install] that comes before gitlab::config

     Failure/Error: it { is_expected.to contain_class('gitlab::install').that_comes_before('gitlab::config') }



     ArgumentError:

       No title provided and "gitlab::config" is not a valid resource reference

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:544:in `extract_type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:529:in `type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource/catalog.rb:353:in `resource'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:204:in `block in check_befores'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:203:in `each'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:203:in `check_befores'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:99:in `matches?'

     # ./spec/classes/init_spec.rb:53:in `block (4 levels) in <top (required)>'

  4) gitlab supported operating systems gitlab class without any parameters on RedHat (CentOS) should contain Class[gitlab::service] that subscribes to gitlab::config

     Failure/Error: it { is_expected.to contain_class('gitlab::service').that_subscribes_to('gitlab::config') }



     ArgumentError:

       No title provided and "gitlab::config" is not a valid resource reference

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:544:in `extract_type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource.rb:529:in `type_and_title'

     # /home/travis/.rvm/gems/ruby-2.3.0/gems/puppet-4.5.3/lib/puppet/resource/catalog.rb:353:in `resource'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:228:in `block in check_subscribes'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:227:in `each'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:227:in `check_subscribes'

     # /home/travis/.rvm/gems/ruby-2.3.0/bundler/gems/rspec-puppet-79d5373dcbfa/lib/rspec-puppet/matchers/create_generic.rb:102:in `matches?'

     # ./spec/classes/init_spec.rb:55:in `block (4 levels) in <top (required)>'

Finished in 16.74 seconds (files took 1 second to load)

44 examples, 4 failures

Failed examples:

rspec ./spec/classes/init_spec.rb:17 # gitlab supported operating systems gitlab class without any parameters on Debian (Jessie) should contain Class[gitlab::install] that comes before gitlab::config

rspec ./spec/classes/init_spec.rb:19 # gitlab supported operating systems gitlab class without any parameters on Debian (Jessie) should contain Class[gitlab::service] that subscribes to gitlab::config

rspec ./spec/classes/init_spec.rb:53 # gitlab supported operating systems gitlab class without any parameters on RedHat (CentOS) should contain Class[gitlab::install] that comes before gitlab::config

rspec ./spec/classes/init_spec.rb:55 # gitlab supported operating systems gitlab class without any parameters on RedHat (CentOS) should contain Class[gitlab::service] that subscribes to gitlab::config
@tobru tobru added the bug Something isn't working label Aug 10, 2016
@tobru
Copy link
Contributor Author

tobru commented Aug 10, 2016

See also https://tickets.puppetlabs.com/browse/PUP-6385

@tobru
Copy link
Contributor Author

tobru commented Aug 10, 2016

Test locally:

docker run --rm -it -v $(pwd):/home/travis/gitlab quay.io/travisci/travis-ruby /bin/bash
su - travis
cd gitlab
export PUPPET_VERSION="~> 4.5.3"
export STRICT_VARIABLES=yes
rvm use 2.3.0 --install --binary --fuzzy
export BUNDLE_GEMFILE=$PWD/Gemfile
rm Gemfile.lock || true
bundle install --without development system_tests
bundle exec rake test

@tobru tobru closed this as completed in e14ef31 Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobru