fixed the use of Integers in gitlab_rails Settings inside gitlab.rb

[rwuest]

Within the rack_attack_git_basic_auth settings in gitlab_rails the support of integer values is needed.
At the moment all Integers will be interpreted as Strings like this:
gitlab_rails['rack_attack_git_basic_auth'] = {"bantime"=>"3600", "enabled"=>true, "findtime"=>"60", "ip_whitelist"=>["127.0.0.1", "195.65.222.171"], "maxretry"=>"10"}

And after the Puppet run with a gitlab reconfiguration gitlab breaks with the following error, as soon as rack_attack is used:
TypeError (String can't be coerced into Fixnum):
lib/gitlab/auth/ip_rate_limiter.rb:16:in reset!' lib/gitlab/auth.rb:51:in rate_limit!'
lib/gitlab/auth.rb:18:in find_for_git_client' app/controllers/projects/git_http_client_controller.rb:117:in handle_basic_authentication'
app/controllers/projects/git_http_client_controller.rb:31:in authenticate_user' lib/gitlab/request_profiler/middleware.rb:15:in call'
lib/gitlab/middleware/go.rb:16:in call' lib/gitlab/middleware/readonly_geo.rb:29:in call'

With the Fix in gitlab.rb.erb the rack_attack_git_basic_auth settings will be interpreted correctly.

[tobru]

Thanks a lot for this contribution which I'll merge now. One small hint: Please don't already set a version number in CHANGELOG and metadata.json, this will be done by the maintainer. However, adding a changelog entry is very much appreciated!

[rwuest]

perfect, thanks for the hint regarding to the versioning, i won't do it in future ;-)