Add backup job #155
Merged
Add backup job #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one has been on my list also, but I think it needs some things before it can be merged. Mainly, removing hardcoded values in favor of parameters. |
b4ldr
force-pushed
the
add_backup_job
branch
3 times, most recently
from
f1159cb
to
3e33f83
Compare
|
@LongLiveCHIEF have updated with params for minute and hour. i also added a param for the gitlab-rake bin although this should not really change. I dont think this needs any further paramertisation but feel free to suggest some |
b4ldr
force-pushed
the
add_backup_job
branch
from
3e33f83
to
ef96f94
Compare
|
Those were the ones I was worried about in order to make it a good PR. If you really wanted bonus points, you could add SKIP's. LGTM as is though. |
b4ldr
force-pushed
the
add_backup_job
branch
from
ef96f94
to
ebd401a
Compare
|
SKIPs was pretty easy to add so have updated the pull request |
|
Unfortunately the addition will cause a broken command syntax. Skips need
to be in a very specific unspaced, comma-sepatated format, and this prints
them out as an array.
The quick win here would be just to change the attribute type to a string
and allow entry of whatever is passed in, leaving it up to the implementer
to pass a valid value for skips.
The other option would be to have a parameter called other_args and just
append that to the backup cron.
…On Sep 5, 2017 8:46 AM, "John Bond" ***@***.***> wrote:
SKIPs was pretty easy to add so have updated the pull request
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIVgW6X-loxM0k7V2FszRwgbKHypASVks5sfVCagaJpZM4O7h-X>
.
|
b4ldr
force-pushed
the
add_backup_job
branch
from
ebd401a
to
38b9c5d
Compare
|
@LongLiveCHIEF you may have missed the join (https://github.com/vshn/puppet-gitlab/pull/155/files#diff-0ac866172efd29d0ddc2aa75ae6f182dR81) although it was joining them on white space before so i have fixed that to a comma |
|
Further to this the reason i prefer an array over a string is for data validation when we move to puppet4. at that point we can do something like types/skip.pptype Gitlab::Skip = Enum[
'db', 'uploads', 'repositories', 'builds',
'artifacts', 'lfs', 'registry', 'pages'
]manifests/init.ppclass gitlab {
...
Array[Gitlab::Skip] $backup_cron_skips
...
} |
|
Yeah, missed that. And speaking of skips... Puppet 5? Lol
…On Sep 6, 2017 6:16 AM, "John Bond" ***@***.***> wrote:
Further to this the reason i prefer an array over a string is for data
validation when we move to puppet4. at that point we can do something like
types/skip.pp
type Gitlab::Skip = Enum['db', 'uploads', 'repositories', 'builds', 'artifacts', 'lfs', 'registry', 'pages']
manifests/init.pp
class gitlab {
...
Array[Gitlab::Skip] $backup_cron_skips
...
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADIVgXgOoxpF2Mg2Zq5JEL_LceaG3UD3ks5sfn8KgaJpZM4O7h-X>
.
|
|
anything preventing this? |
|
Thanks |
mhyzon
pushed a commit
to mhyzon/puppet-gitlab
that referenced
this pull request
Jan 12, 2018
…s managing the backup cron w/o managing the config file and fixing SKIP syntax.
b4ldr
added a commit
to icann-dns/puppet-gitlab
that referenced
this pull request
Apr 3, 2018
# This is the 1st commit message: . # This is the commit message #2: remove duplicate githooks # This is the commit message #3: Refactor cirunners - - update # This is the commit message #4: add deprecation notice # This is the commit message voxpupuli#5: add travis secret for publishing module # This is the commit message voxpupuli#6: release 1.16.0 # This is the commit message voxpupuli#7: rename changelog for release gem # This is the commit message voxpupuli#8: rewrite changelog with github-changelog-generator # This is the commit message voxpupuli#9: [blacksmith] Bump version to 1.16.1-rc0 # This is the commit message voxpupuli#10: modulesync 1.7.0 # This is the commit message voxpupuli#11: modulesync 1.7.0 take 2 # This is the commit message voxpupuli#12: fix spec test hiera location # This is the commit message voxpupuli#13: release 1.16.1 # This is the commit message voxpupuli#14: [blacksmith] Bump version to 1.16.2-rc0 # This is the commit message voxpupuli#15: Propose small spelling change # This is the commit message voxpupuli#16: Fixed redhat installation # This is the commit message voxpupuli#17: add letsencrypt section to gitlab.rb # This is the commit message voxpupuli#18: I think there were some minor problems with voxpupuli#155. This allows managing the backup cron w/o managing the config file and fixing SKIP syntax. # This is the commit message voxpupuli#19: setup fast indexing of ssh keys # This is the commit message voxpupuli#20: add unit test for store_git_keys_in_db # This is the commit message voxpupuli#21: added docs for using store_git_keys_in_db feature # This is the commit message voxpupuli#22: add variable to scope # This is the commit message voxpupuli#23: update regex in ssh fast lookup spec # This is the commit message voxpupuli#24: another stab at regex # This is the commit message voxpupuli#25: typo correction # This is the commit message voxpupuli#26: checking file exists first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pull to add managing the gitlab backup cron job