Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db indexing for git authorized keys #177

Conversation

LongLiveCHIEF
Copy link
Contributor

@LongLiveCHIEF LongLiveCHIEF commented Jan 9, 2018

This enhancement allows for fast lookups for ssh keys for communicating with gitlab instances using git+ssh protocol.

As described in the speed up ssh operations documentation, gitlab has a feature that will allow the gitlab_shell to index authorized_keys for git+ssh connections in the database instead of the authorized_keys file. This can drastically impact the speed of ssh connections when a large number of keys or users are present.

closes #168

@LongLiveCHIEF
Copy link
Contributor Author

so it looks like my builds are failing because there was a network timeout during one of the jobs. Only that one job failed, and all the others passed. Looks like this is a common problem with ruby deps, according to Travis help docs: https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out.

I'm going to close and re-open the PR just to see if it will try to rebuild.

@LongLiveCHIEF LongLiveCHIEF reopened this Jan 11, 2018
@LongLiveCHIEF LongLiveCHIEF merged commit c00e24e into voxpupuli:master Mar 8, 2018
@LongLiveCHIEF LongLiveCHIEF deleted the db-indexing-for-git-authorized_keys branch March 8, 2018 17:47
@LongLiveCHIEF LongLiveCHIEF added this to the Gitlab HA Support milestone Mar 30, 2018
@LongLiveCHIEF LongLiveCHIEF added the enhancement New feature or request label May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow database to index git authorized_keys
1 participant