Added postgres upgrade tasks #182
Conversation
tasks/postgres_upgrade.sh
Outdated
| CMD=$(sudo gitlab-psql --version) | ||
| echo "version is ${CMD##* }" | ||
| #9.2.18 | ||
| if [ "${CMD##* }" = "9.2.18" ]; then |
There was a problem hiding this comment.
would it better to do a -lt 10 here instead of hardcoding a 9.x?
There was a problem hiding this comment.
Not in this case. Refer to the link in the OP's PR.
There was a problem hiding this comment.
@Nekototori sorry it took so long to get to this. I had to familiarize myself with bolt and get used to using it with sudo before I could properly review this request.
I noted in three spots where your script uses sudo explicitly. Tasks/scripts should not have sudo in them, and should instead be run with --sudo --tty --run-as root on the command line.
We also need to add some documentation to README, adding a ##Tasks section, and then adding this as the first task.
Once you clean up the sudo's, and add in some documentation for usage I'll merge. Make sure to mention the --sudo --run-as root --tty bit, since it's currently not documented fully in bolt docs.
Thanks for your contribution!
tasks/postgres_upgrade.sh
Outdated
| #!/bin/bash | ||
|
|
||
| echo 'Checking pgsql version' | ||
| CMD=$(sudo gitlab-psql --version) |
There was a problem hiding this comment.
The sudo needs to come out here, and this task needs to be run with --sudo --tty --run-as root
tasks/postgres_upgrade.sh
Outdated
| echo "Database size is: $DB_SIZE kb and freespace is $FREE kb" | ||
| if [ $DB_SIZE -lt $FREE ]; then | ||
| echo 'Enough freespace available to proceed.' | ||
| sudo gitlab-ctl pg-upgrade |
tasks/post_upgrade.sh
Outdated
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
| echo 'Cleaning up leftover files from upgrade...' | |||
| sudo rm -rf /var/opt/gitlab/postgresql/data.9.2.18 | |||
Was going through upgrading my older gitlab and had to upgrade the postgres database. This task follows the steps and checks here:
https://docs.gitlab.com/omnibus/settings/database.html#upgrade-packaged-postgresql-server
I've broken it up into two. One does the upgrade, and another does the cleanup.