add letsencrypt section to gitlab.rb #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 27, 2018
manifests/init.pp
Outdated
| @@ -374,6 +378,7 @@ | |||
| $gitlab_rails = undef, | |||
| $high_availability = undef, | |||
| $logging = undef, | |||
| $letsencrypt = undef, | |||
There was a problem hiding this comment.
please add a datatype for the new parameter. We try to use them for all new params.
There was a problem hiding this comment.
good point. Will do.
|
Hi @costela, thanks for the PR! Can you nevertheless add a unit test that verifies the content of the file? |
|
@bastelfreak will do! 👍 |
|
@bastelfreak done and done! :) |
|
Thanks! |
guikcd
added a commit
to Oxalide/puppet-gitlab
that referenced
this pull request
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR should be all that's needed to add basic support for the new (gitlab >= 10.5) letsencrypt support.
Please note spec tests are missing, since none of the other hash-based settings seem to have them either.
fixes #199