Refactor resource ordering #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved host_config to front - moved omnibus_config in front of install - closes voxpupuli#240 - made service a non-subscribe in init.pp ordering - required for voxpupuli#239 closes voxpupuli#237
it is recommended to deprecate the params.pp pattern with newer versions of puppet
LongLiveCHIEF
added
enhancement
LongLiveCHIEF
removed
needs-work
LongLiveCHIEF
force-pushed
the
refactor-ordering
branch
from
4e3f767
to
0807eaa
Compare
LongLiveCHIEF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is required as a single pull in order to address (and therefore closes #227 #237 #240).
While refactoring the manifests and resource ordering of this module, I made the following changes:
configmanifest into ahost_configandomnibus_configmanifestpreinstallclass in favor of thehost_configclassparams.ppvariables irelated to refactor, in support of recommended best practices$::gitlabto$gitlabto update variable scope up to date with best practicesBreaking Changes
gitlab::configgitlab::preinstall