Do not manage apt-transport-https. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a refactor of repo/package management coming this weekend, and I'll make sure this is part of that. It will be included in the next release, which should wind up being a major release (`v3.0.0) |
|
lol, n/m, i thought this was an issue and not a PR. LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
since apt-transport-https is in Ubuntu 18.04/Debian 10 just a transitional package it isn't mandatory anymore, the apt-transport-https dependency should be conditional.
Since puppetlabs-apt 4.4.0 handle this correctly I prefer to consume that logic instead build a own.
See:
https://packages.ubuntu.com/bionic/apt-transport-https
https://packages.debian.org/buster/apt-transport-https