Use ubuntu apt repo if we are on ubuntu #279
Conversation
jkroepke
force-pushed
the
fix/deb_ubuntu
branch
from
6c2175b
to
2ddc3ec
Compare
jkroepke
changed the title
|
Thanks @jkroepke ! |
| @@ -25,6 +25,14 @@ | |||
| it { is_expected.to contain_apt__source('gitlab_official_ee').with_ensure('absent') } | |||
| it { is_expected.not_to contain_apt__source('gitlab_official_') } | |||
| it { is_expected.not_to contain_yumrepo('gitlab_official_ce') } | |||
| case facts[:operatingsystem] | |||
There was a problem hiding this comment.
@jkroepke if you get a chance can you submit a pull that uses modern fact for this?
There was a problem hiding this comment.
Last time I'm writing spec test, modern facts are simply not work or not defined by the module you are using for generated the facts.
No idea whats the current state is.
There was a problem hiding this comment.
For information :
structured facts with rspec-puppet : facts[:os]['family']
structured facts with beaker-rspec : fact('os.family')
|
Thanks for the PR, much appreciated! Any other issues installing on Ubuntu? |
I just upgraded from 2.x, puppet changed nothing expect the apt file. I also missed the CI Runner part right now. It's fine to split runner and gitlab into a separate modules, but you should release the runner module. Otherwise a lot of people can not upgrade to the current 3.0. At the end thanks for still supporting this over all the years. |
Fixes #277