Fix gitlab-ctl reconfigure LD_LIBRARY_PATH warning #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures LD_LIBRARY_PATH is unset in the `gitlab-ctl configure` `exec` resource. As shown in https://travis-ci.org/github/voxpupuli/puppet-gitlab/jobs/739916738 on lines 2089-2090, `gitlab-ctl reconfigure` emits a warning when LD_LIBRARY_PATH is set. It emits this warning even if that enviroment variable is empty. Since LD_LIBRARY_PATH is always set by the Puppet wrapper script used in the `puppet` CLI, the `exec` that runs `gitlab-ctl configure` must unset this variable to avoid the warning message.
trevor-vaughan
approved these changes
Nov 5, 2020
lnemsick-simp
deleted the
unset_ld_library_path_gitlab_ctl_reconfigure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This patch ensures LD_LIBRARY_PATH is unset in the
gitlab-ctl configureexecresource.This Pull Request (PR) fixes the following issues
Fixes the LD_LIBRARY_PATH warning emitted at the end of
gitlab-ctl reconfigure.As shown in https://travis-ci.org/github/voxpupuli/puppet-gitlab/jobs/739916738
on lines 2089-2090,
gitlab-ctl reconfigureemits a warning when LD_LIBRARY_PATHis set. It emits this warning even if that environment variable is empty. Since
LD_LIBRARY_PATH is always set by the Puppet wrapper script used in the
puppetCLI, the
execthat runsgitlab-ctl configuremust unset this variable toavoid the warning message.