Add support for the 'package' omnibus configuration hash. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayward
force-pushed
the
package-systemd-config
branch
from
c4e3c58
to
ee30c3b
Compare
|
The CentOS builds are failing as mentioned here - #372 (comment) |
bastelfreak
reviewed
Jan 17, 2021
manifests/init.pp
Outdated
| @@ -130,6 +131,7 @@ | |||
| Optional[Hash] $high_availability = undef, | |||
| Optional[Hash] $logging = undef, | |||
| Optional[Hash] $letsencrypt = undef, | |||
| Optional[Hash] $package = undef, | |||
There was a problem hiding this comment.
can you enforce the datatype a bit? What about this:
Suggested change
| Optional[Hash] $package = undef, | |
| Hash[String[1],String[1]] $package = {}, |
if possible, the default for arrays and hashes should always be an empty hash/array
There was a problem hiding this comment.
I've kept it optional with undef as the default as this is truly an optional param (as are the other hashes). This will also ensure that it won't (at least the header/description for this section) be rendered into the template when it's not supplied.
I've adjusted the data type to Optional[Hash[String[1], Scalar]].
rayward
force-pushed
the
package-systemd-config
branch
from
ee30c3b
to
6202f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow the
packagehash of options - https://gitlab.com/gitlab-org/omnibus-gitlab/blob/0eed527687a2d78ef2efb8f86435acc02a3b6a97/files/gitlab-config-template/gitlab.rb.template#L2150 - to be configured so that options such assystemd_afterandsystemd_wanted_bycan be defined.This Pull Request (PR) fixes the following issues
N/A