Add system hooks management #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A file hook will run on each event so it's up to you to filter events or projects within a file hook code. You can have as many file hooks as you want. Each file hook will be triggered by GitLab asynchronously in case of an event. For a list of events see the system hooks documentation. Reference: http://10.191.3.4/help/administration/file_hooks
bastelfreak
reviewed
May 7, 2021
bastelfreak
reviewed
May 7, 2021
bastelfreak
reviewed
May 7, 2021
bastelfreak
reviewed
May 7, 2021
bastelfreak
reviewed
May 7, 2021
|
thanks for the PR! I made some tiny inline comments, can you please take a look? |
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
|
@bastelfreak for your help! I think I resolved all the your comments |
bastelfreak
reviewed
May 7, 2021
manifests/init.pp
Outdated
| Boolean $config_manage = true, | ||
| Stdlib::Absolutepath $config_file = '/etc/gitlab/gitlab.rb', | ||
| Optional[Hash] $consul = undef, | ||
| Optional[String] $custom_hooks_dir = '/opt/gitlab/embedded/service/gitlab-shell/hooks', |
There was a problem hiding this comment.
since those two variables now have a default value, they cannot be Optional (because you cannot pass undef to it).
when when we already update it we can update the datatype as well
Suggested change
| Optional[String] $custom_hooks_dir = '/opt/gitlab/embedded/service/gitlab-shell/hooks', | |
| Stdlib::Absolutepath $custom_hooks_dir = '/opt/gitlab/embedded/service/gitlab-shell/hooks', |
bastelfreak
reviewed
May 7, 2021
manifests/init.pp
Outdated
| Stdlib::Absolutepath $config_file = '/etc/gitlab/gitlab.rb', | ||
| Optional[Hash] $consul = undef, | ||
| Optional[String] $custom_hooks_dir = '/opt/gitlab/embedded/service/gitlab-shell/hooks', | ||
| Optional[Stdlib::Absolutepath] $system_hooks_dir = '/opt/gitlab/embedded/service/gitlab-rails/file_hooks', |
There was a problem hiding this comment.
Suggested change
| Optional[Stdlib::Absolutepath] $system_hooks_dir = '/opt/gitlab/embedded/service/gitlab-rails/file_hooks', | |
| Stdlib::Absolutepath $system_hooks_dir = '/opt/gitlab/embedded/service/gitlab-rails/file_hooks', |
aligning the = is quite impossible in this code suggestion :D
bastelfreak
reviewed
May 7, 2021
manifests/system_hook.pp
Outdated
| # @param content Specify the system hook contents either as a string or using the template function. If this paramter is specified source parameter must not be present. | ||
| # @param source Specify a file source path to populate the system hook contents. If this paramter is specified content parameter must not be present. | ||
| define gitlab::system_hook ( | ||
| Stdlib::Absolutepath $system_hooks_dir, |
There was a problem hiding this comment.
Suggested change
| Stdlib::Absolutepath $system_hooks_dir, | |
| Stdlib::Absolutepath $system_hooks_dir = $gitlab::system_hooks_dir, |
if we do this we don't need the if/else logic in line 21-25
|
thanks for all the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A file hook will run on each event so it's up to you to filter events
or projects within a file hook code. You can have as many file hooks
as you want. Each file hook will be triggered by GitLab asynchronously
in case of an event. For a list of events see the system hooks
documentation.
Reference: http://10.191.3.4/help/administration/file_hooks
Pull Request (PR) description
This Pull Request (PR) fixes the following issues