Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom hooks #54

Merged
merged 1 commit into from
Mar 11, 2016
Merged

add custom hooks #54

merged 1 commit into from
Mar 11, 2016

Conversation

b4ldr
Copy link
Member

@b4ldr b4ldr commented Feb 12, 2016

I just migrated from using spuder/puppet-gitlab module to this on and found that there was no support for custom hooks. this pull request adds spuder/puppet-gitlab/manifest/custom_hooks.pp to this project

@b4ldr
Copy link
Member Author

b4ldr commented Feb 12, 2016

Not sure why test are failing the all pass when run locally

@petems
Copy link
Member

petems commented Feb 16, 2016

@b4ldr Tests are failing in travis due to strict variable setting, fixed in #57

@b4ldr
Copy link
Member Author

b4ldr commented Feb 17, 2016

thanks @petems, ill wait for that to #57 to get merged then

@tobru
Copy link
Contributor

tobru commented Feb 18, 2016

@b4ldr as #57 has been merged, would you mind rebasing this PR and make sure that the Travis checks pass?

remove undef
@b4ldr
Copy link
Member Author

b4ldr commented Feb 18, 2016

done

@tobru
Copy link
Contributor

tobru commented Feb 18, 2016

Looks good so far. I would really appreciate if you could add this new feature to the README, so that everyone gets aware of it. Thanks

@tobru tobru merged commit 163c20b into voxpupuli:master Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants