Refactor beaker tests for Travis #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petems
commented
Sep 20, 2016
petems
commented
- There are issues running docker in docker in Travis, so lets test the easiest use-case
- Adds a specific Travis spec with the docker workarounds required
- Revert the class spec so tests in Vagrant can still work outside of Travis
petems
force-pushed
the
refactor_beaker_tests
branch
2 times, most recently
from
7d2d048
to
27e4cfc
Compare
* There are issues running docker in docker in Travis, so lets test the easiest use-case * Adds a specific Travis spec with the docker workarounds required * Revert the class spec so tests in Vagrant can still work outside of Travis
petems
force-pushed
the
refactor_beaker_tests
branch
from
27e4cfc
to
6a41290
Compare
|
@petems thanks for the update. Would you mind adding docs for the new parameter before I merge it? |
petems
force-pushed
the
refactor_beaker_tests
branch
from
1519474
to
9b1f8fb
Compare
|
@tobru Done! 👍 |
* Explicitly set the service commands to be run by the `/usr/bin/gitlab-ctl` command rather than a service provider
|
Great, thanks a lot. Let's see what Travis says... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.