CI Runner Update

[LongLiveCHIEF]

Note: Migrated from voxpupuli/puppet-gitlab#120, opened by @cdenneen

---

Currently the method of checking config.toml for runner exists or not needs to be fixed.
While this works for the existence of a runner it doesn't allow for any changes to the runner itself.
The addition of options, tags, image, etc won't generate updated config.toml

It appears somehow the runner hash needs to be compared to current found hash in the config.toml to determine if the runner has updated or not.

To reproduce:

gitlab_ci_runners:
  ruby2.1:
    docker-image: "ruby:2.1"
gitlab_ci_runners_defaults:
  url: "https://gitlab.host/ci"
  registration-token: "XXXX"
  executor: "docker"
  docker-image: "ubuntu:trusty"

to

gitlab_ci_runners:
  ruby2.1:
    docker-image: "ruby:2.FOO"
    tag-list:
      - "ruby2.1"
gitlab_ci_runners_defaults:
  url: "https://gitlab.host/ci"
  registration-token: "XXXX"
  executor: "docker"
  docker-image: "ubuntu:trusty"

Will not update the config.toml to the following:

concurrent = 4
check_interval = 0

[[runners]]
  name = "ruby2.1"
  url = "https://gitlab.host/ci"
  token = "XXXX"
  executor = "docker"
  [runners.docker]
    tls_verify = false
    image = "ruby:2.FOO"
    privileged = false
    disable_cache = false
  [runners.cache]

Also the tag update for the runner isn't something that gets written to config.toml but updated in gitlab so that needs to be checked as well.

Only solution so far would be to empty config.toml and delete the runners in Gitlab UI... then run puppet and it will recreate the runners with current configuration and proper tags.

[Dan33l]

FYI : https://gitlab.com/gitlab-org/gitlab-runner/issues/3022

[bogomips]

Same problem here,
did you guys find a solution?

would unregister and re-register the runner be a workaround?

[AKuederle]

Does unregistering a runner also remove it from the gitlab interface? Because if your just delete runners from the config file, you need to additionally manually remove them in the interface

[cdenneen]

If I recall if you unregister the runner but the config.toml still has it, then no new runner will be registered. You have to unregister and delete from config.toml in order for it to be recreated/registered

To @tobru point (voxpupuli/puppet-gitlab#120 (comment)) maybe this would need to be implemented with puppet tasks?