Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing 'configtimeout' as a setting is deprecated #54

Closed
seanmil opened this issue Mar 26, 2020 · 0 comments · Fixed by #55
Closed

Accessing 'configtimeout' as a setting is deprecated #54

seanmil opened this issue Mar 26, 2020 · 0 comments · Fixed by #55

Comments

@seanmil
Copy link

seanmil commented Mar 26, 2020

When running a Puppet run containing tcp_conn_validator I saw this warning emitted by Puppet:

Warning: Accessing 'configtimeout' as a setting is deprecated.
   (location: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/settings.rb:1165:in `issue_deprecation_warning')

and traced it back to this line: https://github.com/voxpupuli/puppet-healthcheck/blob/master/lib/puppet_x/puppet-community/tcp_validator.rb#L31
b4ldr added a commit to b4ldr/puppet-healthcheck that referenced this issue Mar 27, 2020
@b4ldr
replace configtimeout with http_connect_timeout (voxpupuli#54)
042e7b0 
configtimeout is deprecated in favour of  http_connect_timeout and
http_read_timeout.  this PR updates configtimeout with
http_connect_timeout which seems reasonable however im not familiar with
this module so let me know if read_timeout makes more sense

closes voxpupuli#54
@b4ldr b4ldr mentioned this issue Mar 27, 2020
Merged
bastelfreak added a commit that referenced this issue Apr 5, 2020
@bastelfreak
Merge pull request #55 from b4ldr/configtimeout
f677376 
replace configtimeout with http_connect_timeout (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace configtimeout with http_connect_timeout (#54) b4ldr/puppet-healthcheck
1 participant
@seanmil