http_conn_validator: Initial commit #2
Conversation
|
A lot of the comments on #1 apply here. I suggest we focus review there then apply those decisions here. |
|
@Spredzy ping |
| @@ -1 +1,45 @@ | |||
| # puppet-healthcheck | |||
|
|
|||
There was a problem hiding this comment.
Right now this conflicts with the existing tcp_conn_validator code. It'll need to be reworked.
Spredzy
force-pushed
the
http_conn_validator
branch
from
f7b9211
to
3798bfe
Compare
Initial commit of the new provider http_conn_validator that allows
one to check if a web service is actually listening on a given ip,
port and specific URL. The https protocol can be used if specified.
It supports both IPv4 and IPv6 address.
It either takes a string connection in the namevar or received the
informations through the `server`, `port`, `use_ssl` and `test_url`
parameters.
Case 1:
http_conn_validator { 'https://127.0.0.1:8080/test_url' : }
Case 2:
http_conn_validator { 'local elasticsearch' :
host => '127.0.0.1',
port => 9200,
}
Spredzy
force-pushed
the
http_conn_validator
branch
from
3798bfe
to
57ec207
Compare
|
@igalic @nibalizer Until I find a proper solution to address comment on #3 can we go ahead with this one (it matches #1) and will resubmit a review when a solution for reachable/check solution will be found |
|
@Spredzy, from what i gather, @adrienthebo's ensurable comment should be equally valid for this check |
|
@igalic Agree but I'd like to do that in a second patchset. This current commit offers the same feature as the one currently available on tcp_conn_validator. I need to work on a different patchset to bring @adrienthebo's suggestion on both providers. |
http_conn_validator: Initial commit
Initial commit of the new provider http_conn_validator that allows
one to check if a web service is actually listening on a given ip,
port and specific URL. The https protocol can be used if specified.
It supports both IPv4 and IPv6 address.
It either takes a string connection in the namevar or received the
informations through the
server,port,use_sslandtest_urlparameters.
Case 1:
http_conn_validator { 'https://127.0.0.1:8080/test_url' : }Case 2:
http_conn_validator { 'local elasticsearch' : server => '127.0.0.1', port => 9200, }