replace configtimeout with http_connect_timeout (#54) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configtimeout is deprecated in favour of http_connect_timeout and http_read_timeout. this PR updates configtimeout with http_connect_timeout which seems reasonable however im not familiar with this module so let me know if read_timeout makes more sense closes voxpupuli#54
|
Thanks for the PR. Do you know when |
bastelfreak
added
bug
|
looks like it was deprecated in puppet 4.0.0 https://tickets.puppetlabs.com/browse/PUP-3666 |
I am not able to open tis Jira issue, but it looks like I saw the new parameter in the Puppet 4 docs, but this module only supports Puppet 5/6. |
dhoppe
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configtimeout is deprecated in favour of http_connect_timeout and
http_read_timeout. this PR updates configtimeout with
http_connect_timeout which seems reasonable however im not familiar with
this module so let me know if read_timeout makes more sense
Fixes #54