Add parameter for expected HTTP code #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -58,7 +58,7 @@ def create | |||
| # | |||
| # @api private | |||
| def validator | |||
| @validator ||= PuppetX::PuppetCommunity::HttpValidator.new(resource[:name], resource[:host], resource[:port], resource[:use_ssl], resource[:test_url]) | |||
| @validator ||= PuppetX::PuppetCommunity::HttpValidator.new(resource[:name], resource[:host], resource[:port], resource[:use_ssl], resource[:test_url], resource[:expected_code]) | |||
|
@Dvorak would you mind also adding this new parameter to the readme? |
|
Hello: What's the status of this PR? |
|
ping @Dvorak |
Allow user to specify the expected HTTP result code. Defaults to 200.
claytono
force-pushed
the
expected-code
branch
from
fb713a2
to
a6c8a37
Compare
|
Wrapped the ugly line I had made slightly uglier and added to README |
|
LGTM. |
jyaworski
added a commit
that referenced
this pull request
Jan 26, 2016
Add parameter for expected HTTP code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify the expected HTTP result code. Defaults to 200.