Fix #61 - Migrate to new runtime client

[duritong]

This removes the deprecation warning and imho keeps the current behavior. Although the new interface would allow for more options (e.g. use dedicated certs or puppet ca and so on).

[kbucheli]

That PR also fixes another problem I ran into, as the deprecated part seams not to use the systems CA list (or has an outdated one):

Notice: Unable to connect to the server (https://server.xyz.com:443): certificate verify failed [self signed certificate in certificate chain for CN=DigiCert High Assurance EV Root CA,OU=www.digicert.com,O=DigiCert Inc,C=US]

(puppet agent 7.90.0 on RedHat Enterprise Linux 7.9)

Is there a timetable for merge? What is missing?

[kbucheli]

Looks like it is not perfect yet, when I test a failing check (returning a 404), I get a few errors:

Notice: Unable to connect to the server (https://server.xyz.com/foobar/): undefined method `msg' for #<Puppet::HTTP::ResponseNetHTTP:0x0000000004f07108>
Notice: Failed to make an HTTP connection within timeout window of 60 seconds; giving up.
Error: Could not set 'present' on ensure: undefined method `http_server' for #<PuppetX::PuppetCommunity::HttpValidator:0x00000000054cdbf0> (file: /srv/puppet/code/dev/envs/failfast_missing_foobar/code/modules/profile/manifests/foobar.pp, line: 78)
Error: Could not set 'present' on ensure: undefined method `http_server' for #<PuppetX::PuppetCommunity::HttpValidator:0x00000000054cdbf0> (file: /srv/puppet/code/dev/envs/failfast_missing_foobar/code/modules/profile/manifests/foobar.pp, line: 78)
Wrapped exception:
undefined method `http_server' for #<PuppetX::PuppetCommunity::HttpValidator:0x00000000054cdbf0>
Error: /Stage[pre]/Profile::Foobar/Http_conn_validator[https://server.xyz.com/foobar/]/ensure: change from 'absent' to 'present' failed: Could not set 'present' on ensure: undefined method `http_server' for #<PuppetX::PuppetCommunity::HttpValidator:0x00000000054cdbf0> (file: /srv/puppet/code/dev/envs/failfast_missing_foobar/code/modules/profile/manifests/foobar.pp, line: 78)
Notice: /Stage[pre]/Profile::Foobar/File[/etc/yum/vars/pli_repo_tag]: Dependency Http_conn_validator[https://server.xyz.com/foobar/] has failures: true

[vox-pupuli-tasks]

Dear @duritong, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks