Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/32 is incorrectly stripped from IPv6 networks #30

Closed
LionelCons opened this issue Mar 30, 2020 · 3 comments · Fixed by #66
Closed

/32 is incorrectly stripped from IPv6 networks #30

LionelCons opened this issue Mar 30, 2020 · 3 comments · Fixed by #66
Labels
bug Something isn't working needs-tests needs-work not ready to merge just yet

Comments

@LionelCons
Copy link

ipset_sync incorrectly strips /32 from IPv6 networks (e.g. fe80::/32).

This happens here: https://github.com/voxpupuli/puppet-ipset/blob/master/files/ipset_sync#L77

/32 should only be stripped if family is inet. Similarly, /128 should only be stripped if family is inet6 (but this is not a problem in practice).

@bastelfreak
Copy link
Member

hey @LionelCons, thanks for bringing this up. are you able to provide a PR for this?

@LionelCons
Copy link
Author

Sorry but I do not use puppet-ipset anymore.

@maxadamo
Copy link
Contributor

fixed by of #66
duplicate of #65
I wrongly open a new issue which is the same as this one.
I close mine and I leave this one open, which is older.

@ekohl ekohl linked a pull request May 23, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-tests needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants