Fix Rubocop/puppet-lint warnings & broken travis config & broken acceptance tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the type conflicts with the name of our defined resource.
this won't work because Puppet *still* hasn't published any debs for it.
bastelfreak
changed the title
alexjfisher
reviewed
Oct 1, 2019
alexjfisher
reviewed
Oct 1, 2019
| systemd: true | ||
| systemd: true, | ||
| operatingsystem: 'RedHat', | ||
| osfamily: 'RedHat' | ||
| } | ||
| end | ||
|
|
||
| check_file_set_header( |
There was a problem hiding this comment.
this looks a bit funky. Is it why EmptyExampleGroup fires? Should you be using shared examples and it_behaves_like instead??
There was a problem hiding this comment.
this whole testsetup is a bit funky. Should we keep it as-is for now and refactor it later? Otherwise the diff gets even bigger.
sebastianrakel
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.