fix systemd unit dependencies #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, ipset had a dependency to a working network connection (with available ip addresses and routes and stuff like this), if systemd-networkd was used. This doesn't make any sense and might even introduce dependency cycles. We can start as soon as the kernel is ready to accept calls from ipset. And we need to start before iptables tries to use us. This will be fixed in a seperate commit.
This service should start before iptables/ip6tables starts. This is based on https://git.archlinux.org/svntogit/packages.git/tree/trunk/ipset.service?h=packages/ipset It's not required to wait for the whole network stack to come available to add ipsets.
ekohl
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service should start before iptables/ip6tables starts. This is based on https://git.archlinux.org/svntogit/packages.git/tree/trunk/ipset.service?h=packages/ipset It's not required to wait for the whole network stack to come available to add ipsets.