Override DefaultDependencies on ipset service unit #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any feedback on this PR? (I'm not entirely sure why the Archlinux test failed, but I note that it's failing on other PRs). Thanks! |
|
Hi @sagepe , thanks for the PR. Can you please rebase against our latest master branch? |
The current ipset service unit sets `Before=network-pre.target` as it is needed before the network to help ensure that the firewall is up and running before anyone might actually try to connect. It has no setting for `DefaultDependencies` which means it takes the defaults, one of which is `After=sysinit.target`. There are some cases where this can cause a dependency cycle with other units that want to start early in the boot process between `networking.service` and `sysinit.target` (for example, cloud-init). This results in one of the offending units being removed and risks startup continuing without ipsets being configured, potentially leaving a firewall open and a host at risk. The ipset service can safely be run before `sysinit.target` by setting `DefaultDependencies=no` with a couple of additional dependencies to handle some of the other implied settings that are removed as a result. Fixes voxpupuli#63
sagepe
force-pushed
the
63-systemd-dependencies
branch
from
bef058f
to
348f1f2
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The current ipset service unit sets
Before=network-pre.targetas it is needed before the network to help ensure that the firewall is up and running before anyone might actually try to connect. It has no settingfor
DefaultDependencieswhich means it takes the defaults, one of which isAfter=sysinit.target.There are some cases where this can cause a dependency cycle with other units that want to start early in the boot process between
networking.serviceandsysinit.target(for example, cloud-init). This results in one of the offending units being removed and risks startup continuing without ipsets being configured, potentially leaving a firewall open and a host at risk.The ipset service can safely be run before
sysinit.targetby settingDefaultDependencies=nowith a couple of additional dependencies to handle some of the other implied settings that are removed as a result.This Pull Request (PR) fixes the following issues
Fixes #63