Enable CentOS/RHEL 8 support, stop triggering sync exec when nothing changes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
reviewed
Aug 1, 2022
| # only when difference with in-kernel set is detected | ||
| unless => "ipset_sync -c '${config_path}' -d -i ${title}${ignore_contents_opt}", | ||
| require => Package['ipset'], | ||
| unless => "ipset_sync -c '${config_path}' -d -i ${title}${ignore_contents_opt}", |
There was a problem hiding this comment.
Why is the unless test not working on EL8?
There was a problem hiding this comment.
Looked into this briefly, but came up empty. So for now all I know is it doesn't work, but not why :/
There was a problem hiding this comment.
@bastelfreak Heya, I know this is a very stupid solution and probably not a proper fix. But I can't seem to find another solution. But it would be nice to finally have these eye soar ipset sync messages gone from our foreman reports :)
There was a problem hiding this comment.
took me a bit to read the code, but I think the refreshonly is fine. We notify the exec resource when keep_in_sync is true, and it doesn't make sense to always run it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.