Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is a fix for newer kernel and resolves #68 #81

Merged
merged 3 commits into from
Oct 20, 2023
Merged

this is a fix for newer kernel and resolves #68 #81

merged 3 commits into from
Oct 20, 2023

Conversation

muncjack
Copy link
Contributor

Pull Request (PR) description

This is for resolving a problem with ipset on ubuntu 22.04 LTS
The new version of ipset add extra header messages

This Pull Request (PR) fixes the following issues

Fixes #68

@bastelfreak
Copy link
Member

Can you place add Ubuntu 22.04 to metadata.json?

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 14, 2023
@maxadamo maxadamo added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Mar 14, 2023
@muncjack
update metadata.json to add ubuntu 22.04
f942cc0 
adding ubuntu 22.04 to metadata.json
@muncjack
Copy link
Contributor Author

I have added ubuntu to the metadata.json file :-)

@maxadamo
Copy link
Contributor

@bastelfreak sorry for messing up with the labels.
Now Ubuntu 22.04 was added, and it looks good to me.

maxadamo
maxadamo approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@maxadamo maxadamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sed commands were moved inside the function, and they are the same as in #67 , but the pre-prending space is also removed (which was necessary)

@maxadamo maxadamo changed the title this is a fix for newer kernel and resolves Fixes #68 this is a fix for newer kernel and resolves #68 Mar 18, 2023
This was referenced Oct 19, 2023
Closed
Closed
@maxadamo
Copy link
Contributor

supersedes #67

@maxadamo maxadamo merged commit 29ca388 into voxpupuli:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxadamo maxadamo maxadamo approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The module doesn't work if ipset in use
3 participants
@muncjack @bastelfreak @maxadamo