Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port parameter ignored #214

Closed
cdenneen opened this issue Nov 13, 2014 · 2 comments
Closed

port parameter ignored #214

cdenneen opened this issue Nov 13, 2014 · 2 comments
Labels
bug Something isn't working

Comments

@cdenneen
Copy link
Contributor

[root@ctcgit01 ~]# puppet apply -v -e "class {'jenkins': port => '8081', configure_firewall => true, }"
Info: Loading facts in /etc/puppet/modules/firewall/lib/facter/ip6tables_version.rb
Info: Loading facts in /etc/puppet/modules/firewall/lib/facter/iptables_version.rb
Info: Loading facts in /etc/puppet/modules/firewall/lib/facter/iptables_persistent_version.rb
Info: Loading facts in /etc/puppet/modules/jenkins/lib/facter/jenkins.rb
Info: Loading facts in /etc/puppet/modules/apt/lib/facter/apt_update_last_success.rb
Info: Loading facts in /etc/puppet/modules/apt/lib/facter/apt_updates.rb
Info: Loading facts in /etc/puppet/modules/vmwaretools/lib/facter/vmwaretools_version.rb
Info: Loading facts in /etc/puppet/modules/vmwaretools/lib/facter/esx_version.rb
Info: Loading facts in /etc/puppet/modules/stdlib/lib/facter/root_home.rb
Info: Loading facts in /etc/puppet/modules/stdlib/lib/facter/pe_version.rb
Info: Loading facts in /etc/puppet/modules/stdlib/lib/facter/facter_dot_d.rb
Info: Loading facts in /etc/puppet/modules/stdlib/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/ip6tables_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/root_home.rb
Info: Loading facts in /var/lib/puppet/lib/facter/pe_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/iptables_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/concat_basedir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/facter_dot_d.rb
Info: Loading facts in /var/lib/puppet/lib/facter/puppet_vardir.rb
Info: Loading facts in /var/lib/puppet/lib/facter/vmwaretools_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/esx_version.rb
Info: Loading facts in /var/lib/puppet/lib/facter/iptables_persistent_version.rb
Notice: Compiled catalog for ctcgit01.ap.org in environment production in 1.80 seconds
Info: Applying configuration version '1415903482'
Notice: Finished catalog run in 0.80 seconds
[root@ctcgit01 ~]# grep -i port /etc/sysconfig/jenkins
# files (checkouts, build reports, artifacts, ...).
# Port Jenkins is listening on.
JENKINS_PORT="8080"
# HTTPS port Jenkins is listening on.
JENKINS_HTTPS_PORT=""
# Ajp13 Port Jenkins is listening on.
JENKINS_AJP_PORT="8009"

Also as other's have pointed out in #197 HTTP_PORT added to config_hash just adds to config doesn't update JENKINS_PORT... that actually needs to be replaced.

@mlehner616
Copy link

So contrary to what's documented, you were actually on the right track with the config hash as a workaround. If you specify the JENKINS_PORT this will actually work. I use hiera, so it'd look like this

---
jenkins::config_hash:
  JENKINS_PORT:
    value: 6589

A few things to add to this bug:

  1. The documentation doesn't clearly point out that ports such as 80/443 are privileged ports and will not work (some sort of proxy is required to route incoming port 80 traffic to jenkins to this modules default of 8080)

  2. The documentation points the user to enter HTTP_PORT in the config_hash to configure the port however the actual parameter required is JENKINS_PORT (At least tested on EL6).

  3. The jenkins::port parameter in init.pp is defined but never used in the manifest so this is just a configuration black hole

@cdenneen
Copy link
Contributor Author

oddly it is only used in the firewall config but only does HTTP port. So what happens if you specify HTTP and HTTPS.

Also I noticed the plugin syntax says it works but when I open Jenkins site they aren't installed. Anyone else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants