New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puppetlabs/apt from hard dependencies #786

Closed
cfoehrdes opened this Issue Aug 5, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@cfoehrdes

cfoehrdes commented Aug 5, 2017

The puppetlabs/apt dependency causes conflicts with other modules and should not be included as hard dependency according to the puppet style https://docs.puppet.com/puppet/latest/style_guide.html#dependencies.

Maybe consider removing it from the metadata or updating it?

@cristianbalan-mf

This comment has been minimized.

Show comment
Hide comment
@cristianbalan-mf

cristianbalan-mf commented Sep 1, 2017

I agree...

@mmoll

This comment has been minimized.

Show comment
Hide comment
@mmoll

mmoll Sep 2, 2017

Contributor

I don't agree, as otherwise at least also the zypprepo dependency woudl need to get removed

Contributor

mmoll commented Sep 2, 2017

I don't agree, as otherwise at least also the zypprepo dependency woudl need to get removed

@cristianbalan-mf

This comment has been minimized.

Show comment
Hide comment
@cristianbalan-mf

cristianbalan-mf Sep 4, 2017

Then we should upgrade the required dependency to accommodate apt 4 and/or 3 at least.

cristianbalan-mf commented Sep 4, 2017

Then we should upgrade the required dependency to accommodate apt 4 and/or 3 at least.

@mmoll

This comment has been minimized.

Show comment
Hide comment
@mmoll

mmoll Sep 4, 2017

Contributor

The current code is indeed compatible with pl-apt 2.1 to the latest released version.

Contributor

mmoll commented Sep 4, 2017

The current code is indeed compatible with pl-apt 2.1 to the latest released version.

@cristianbalan-mf

This comment has been minimized.

Show comment
Hide comment
@cristianbalan-mf

cristianbalan-mf Sep 4, 2017

Actually, apt must have been sorted as for 0fc1429. Hopefully, we'll see all this in Puppet Forge soon.

cristianbalan-mf commented Sep 4, 2017

Actually, apt must have been sorted as for 0fc1429. Hopefully, we'll see all this in Puppet Forge soon.

@jhoblitt

This comment has been minimized.

Show comment
Hide comment
@jhoblitt

jhoblitt Nov 14, 2017

Member

I'm closing this as I don't believe there is any action to be taken.

Member

jhoblitt commented Nov 14, 2017

I'm closing this as I don't believe there is any action to be taken.

@jhoblitt jhoblitt closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment