Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensure parameter to jenkins::slave #150

Merged
merged 1 commit into from Sep 22, 2014

Conversation

Projects
None yet
4 participants
@carlossg
Copy link
Member

carlossg commented Jul 16, 2014

Allows running the slave manually instead of a service, useful in Docker for instance

@rtyler

This comment has been minimized.

Copy link
Contributor

rtyler commented Jul 16, 2014

@carlossg could I convince you to add an rspec-puppet example or two to verify that passing a class parameter into the jenkins::slave class gets to the service correctly?

@carlossg

This comment has been minimized.

Copy link
Member Author

carlossg commented Jul 16, 2014

Added. The travis build is broken from the previous commit.
You may consider switching rcov to simplecov. rcov doesn't work in 1.9 and it's a native gem that needs to be compiled https://github.com/relevance/rcov

@jenkinsadmin

This comment has been minimized.

Copy link

jenkinsadmin commented Jul 16, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@carlossg

This comment has been minimized.

Copy link
Member Author

carlossg commented Jul 28, 2014

do you need anything else?

@carlossg carlossg force-pushed the maestrodev:slave-ensure branch from fa3e130 to 5a38631 Aug 22, 2014

@carlossg

This comment has been minimized.

Copy link
Member Author

carlossg commented Aug 22, 2014

rebased

@justinclayton

This comment has been minimized.

Copy link

justinclayton commented Aug 23, 2014

it's failing presumably only because of the pending test?

@carlossg

This comment has been minimized.

Copy link
Member Author

carlossg commented Aug 23, 2014

puppet-lint error. Previous builds used puppet-lint 0.3.2, this one used 1.0.1

The command "rake lint" exited with 1.
@carlossg

This comment has been minimized.

Copy link
Member Author

carlossg commented Aug 23, 2014

lint issues fixed in #167

Add ensure parameter to jenkins::slave
Allows running the slave manually instead of a service, useful in Docker for instance

@carlossg carlossg force-pushed the maestrodev:slave-ensure branch from 5a38631 to bd892f3 Aug 25, 2014

@rtyler rtyler added this to the 1.2.0: Nestor milestone Sep 22, 2014

rtyler added a commit that referenced this pull request Sep 22, 2014

Merge pull request #150 from maestrodev/slave-ensure
Add ensure parameter to jenkins::slave

@rtyler rtyler merged commit 5675931 into voxpupuli:master Sep 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@carlossg carlossg deleted the maestrodev:slave-ensure branch Sep 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.