modulesync 2.7.0 and drop puppet 4

[bastelfreak]

modulesync 2.7.0

[alexjfisher]

Does #898 need to be merged first??

[mmoll]

What's the status here?

[bastelfreak]

@mmoll I am pretty swamped with work at the moment and I don't have enough time here. Are you interested in helping us and and working through the failed tests?

[rnelson0]

Can this get a rebase, after the recent metadata changes to ensure it reflects the latest and greatest before troubleshooting any test failures?

[bastelfreak]

@rnelson0 I rebased it. I've a feeling that the acceptance tests aren't idempotent :(

[alexjfisher]

I rebased it. I've a feeling that the acceptance tests aren't idempotent :(

FWIW, I restarted the travis build about 5 times today until this went green.

[mmoll]

Time for a new forge relase, perhaps? :)

[Dan33l]

I've a feeling that the acceptance tests aren't idempotent :(

Hum ... i suppose you wanted to say that acceptance tests highlight an idempotency issue of puppet code.

[bastelfreak]

@Dan33l I've no idea if this is caused by docker or jenkins or puppet.

[Dan33l]

@bastelfreak i don't have idea about the root cause and i am not user of module.

But few months ago i update acceptance tests to be able to get a clearer message when it fail.
And what i saw is that same puppet code applied twice can be not idempotent.