Fix code ordering for ubuntu 18.04 and puppet6

[asifbadkarma]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes : #920

[gittygoo]

Can this be merged? seems to work for me

[ekohl]

This doesn't look correct to me. My impression is that you first need to stop the old sysvinit service and then you can define the new service. Otherwise systemd will just stop the systemd based service but leave sysvinit around.

[asifbadkarma]

Anything I need to do to improve this and maybe get it merged ?

[ekohl]

I think your solution is incorrect. Once the systemd unit file is in place, systemd will use that to stop the service. However, the entire goal of the transition is to stop the service using the sysvinit script before removing that script. Only then can you start to set up systemd based services. While your change may appear to work, I don't think the transition has any effect anymore.

It also breaks the tests.

[vox-pupuli-tasks]

Dear @asifbadkarma, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[ekohl]

Closing for inactivity.