Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira Service Desk doesn't start with JasperListener / need relaxedPath with correct version comp #288

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@thonixx
Copy link
Contributor

thonixx commented Mar 6, 2019

Pull Request (PR) description

Pull request of #260 (issue #259) wanted to prevent JasperListener to be
activated for Service Desk. Version comp condition can't be fulfilled as
Jira and Service Desk have different version numbers.

Therefore JasperListener gets added to the server.xml anyway with Service Desk. To get Service Desk working we need to adapt the condition to not match when we run Jira Service Desk.

Also relaxedPath options only needed from Jira version >v7.12.1 and Service Desk

(According to https://confluence.atlassian.com/jirakb/changing-server-xml-to-handle-requests-with-special-characters-958453799.html)

We need to have relaxedPathChars and relaxedQueryChars set according to
the FAQ page of Atlassian with Jira version greater than 7.12.1 and
apparently Service Desk.

This Pull Request (PR) fixes the following issues

Issue does not exist (yet), relates to issue #259 which doesn't work. Also relaxedPath should only be configured with the correct versions and for Service Desk.

thonixx added some commits Mar 6, 2019

Jira Service Desk doesn't start with JasperListener on
Pull request of #260 (issue #259) wanted to prevent JasperListener to be
activated for Service Desk. Version comp condition can't be fulfilled as
Jira and Service Desk have different version numbers.
relaxedPath options only needed from Jira version >v7.12.1 and Servic…
…e Desk

According to
https://confluence.atlassian.com/jirakb/changing-server-xml-to-handle-requests-with-special-characters-958453799.html
we need to have relaxedPathChars and relaxedQueryChars set according to
the FAQ page of Atlassian with Jira version greater than 7.12.1 and
apparently Service Desk.

@thonixx thonixx changed the title Jira Service Desk doesn't start with JasperListener on Jira Service Desk doesn't start with JasperListener / need relaxedPath with correct version comp Mar 6, 2019

@bastelfreak bastelfreak added the bug label Mar 6, 2019

@bastelfreak

This comment has been minimized.

Copy link
Member

bastelfreak commented Mar 6, 2019

thanks for the fix @thonixx !

@bastelfreak bastelfreak merged commit 84a81e7 into voxpupuli:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fabiogermann fabiogermann referenced this pull request Mar 7, 2019

Open

Tomcat connectors #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.