Sync setenv.sh with upstream 8.13.5 (LTS) #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I decided to remove the heapdump setting because it's not on by default and theoretically could leak some data from memory to disk. I'm not sure why the module enabled it by default previously. |
|
Though on second thought, I think less disruptive would be to just add a new parameter that's preferred over |
This undeprecates $java_opts for backwards compatibility and repurposes the other parameters to do what a custom $jvm_type did previously. It removes "-XX:HeapDumpOnOutOfMemoryError" because that's not a default setting in the upstream setenv.sh It also makes setting $jvm_permgen a no-op, since JIRA doesn't support JDK older than 8 anymore and the option does nothing
|
The merge conflict was with a redundant test |
bastelfreak
approved these changes
Apr 16, 2021
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
* Sync setenv.sh settings with upstream and reduce diff This undeprecates $java_opts for backwards compatibility and repurposes the other parameters to do what a custom $jvm_type did previously. It removes "-XX:HeapDumpOnOutOfMemoryError" because that's not a default setting in the upstream setenv.sh It also makes setting $jvm_permgen a no-op, since JIRA doesn't support JDK older than 8 anymore and the option does nothing * Add maintainer note about sticking close to upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undeprecates $java_opts for backwards compatibility
and repurposes the other parameters to do what a custom $jvm_type
did previously.
It removes "-XX:HeapDumpOnOutOfMemoryError" because that's
not a default setting in the upstream setenv.sh
It also makes setting $jvm_permgen a no-op, since JIRA doesn't support
JDK older than 8 anymore and the option does nothing