Skip to content

Install LE package on EL7, Ubuntu 16.04 and Debian 9+ #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2016

Conversation

domcleal
Copy link
Contributor

A new $install_method parameter to letsencrypt allows selection between
a git/VCS based installation and a package based installation. It
defaults to packages on newer OSes where they're available - in EPEL7,
and upcoming Debian and Ubuntu releases.

Installation has been moved into letsencrypt::install and the LE command
itself is determined by the installation method.

A new $install_method parameter to letsencrypt allows selection between
a git/VCS based installation and a package based installation.  It
defaults to packages on newer OSes where they're available - in EPEL7,
and upcoming Debian and Ubuntu releases.

Installation has been moved into letsencrypt::install and the LE command
itself is determined by the installation method.
@danzilio
Copy link
Member

Thanks @domcleal, this is awesome!! Do you think we should manage EPEL in this? I'm just wondering if $install_method = 'package' is a sane default for EL if we're not expressing the dependency on EPEL. Also, what do you think about adding a default case for $::osfamily in letsencrypt::params with $install_method = 'vcs'?

@domcleal
Copy link
Contributor Author

domcleal commented Feb 1, 2016

Yeah, I share your concern about it not working out of the box on EL7, but I'm hesitant to manage EPEL as it could be quite an intrusive change for some users.

I updated the PR to add a soft dependency on the common stahnma/epel module, with correct ordering of the Yumrepo vs. Package resource, but disabled by default (so as not to require it in metadata.json).

I've also dropped the unsupported OS case and defaulted it to a VCS installation as you suggested.

Dominic Cleal added 2 commits February 1, 2016 10:28
EPEL repo is configured with a soft dependency on stahnma/epel and
disabled by default.
@danzilio
Copy link
Member

danzilio commented Feb 1, 2016

This is excellent! Thank you @domcleal!

danzilio added a commit that referenced this pull request Feb 1, 2016
Install LE package on EL7, Ubuntu 16.04 and Debian 9+
@danzilio danzilio merged commit d706734 into voxpupuli:master Feb 1, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-letsencrypt that referenced this pull request Oct 23, 2017
Install LE package on EL7, Ubuntu 16.04 and Debian 9+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants