Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns-azure to allowed plugins #298

Merged
merged 1 commit into from Jan 13, 2023
Merged

Conversation

yachub
Copy link
Contributor

@yachub yachub commented Oct 1, 2022

Pull Request (PR) description

Add dns-azure to list of allowed plugins.

This is one of the 3rd party plugins listed at https://eff-certbot.readthedocs.io/en/stable/using.html#third-party-plugins

Caveat

I'm currently using this module on my branch on a RHEL 9 host, but the only caveat is the fastest way I found to get the plugin working was via the snap package:

include snap

package { 'certbot':
  ensure          => installed,
  provider        => 'snap',
  install_options => ['classic'],
}

file { '/usr/bin/certbot':
  ensure  => link,
  source  => '/snap/bin/certbot',
  require => Package['certbot'],
}

package { 'certbot-dns-azure':
  ensure          => installed,
  provider        => 'snap',
  install_options => ['channel=edge'],
  require         => Package['certbot'],
}

And also had to run snap set certbot trust-plugin-with-root=ok before the last package resource, but didn't take the time yet to examine what changed on disk in order to create an exec resource to do that.

@bastelfreak bastelfreak added the enhancement New feature or request label Oct 7, 2022
@bastelfreak
Copy link
Member

thanks for the PR! Can you please document your steps in the README.md?

@yachub
Copy link
Contributor Author

yachub commented Oct 7, 2022

thanks for the PR! Can you please document your steps in the README.md?

Absolutely!

@root-expert
Copy link
Member

root-expert commented Nov 25, 2022

@yachub kinda off-topic

Are you by any chance using my module ?

It has a snap_conf resource to set snap set certbot trust-plugin-with-root=ok but seems I forgot to document it on the readme file :p.
You can check REFERENCE for more info.

Edit:

Something like this will work:

snap_conf { 'trust plugin with root dns-azure':
    ensure => present
    conf     => 'trust-plugin-with-root'
    value    => 'ok'
    snap     => 'certbot'
}

@dduportal
Copy link

Hello there 👋 Dropping a message on behalf of the infrastructure team for the Jenkins project. We would be interested by this feature as we have puppet-managed (private) VMs on Azure that would benefit from this.

Thanks for the huge work!

@ekohl ekohl merged commit 885fa73 into voxpupuli:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants