Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and bug fixes #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

liviuvalsan
Copy link
Contributor

Pull Request (PR) description

A few improvements and bug fixes

This Pull Request (PR) fixes the following issues

CakeReque version is now a parameter instead of being hardcoded
Changed default event threat level to match the MISP default and added a config option for the default event tag collection
Bug fix: Elasticsearch connection string and index name need to be string escaped
Changed default value for session auto regenerate to match MISP default and removed un-necessary quoting of config options
Changed the default MISP version installed to version 2.4.102 and added extra dependency introduced in MISP version 2.4.102

@@ -25,6 +25,7 @@ $config = array (
'live' => <%= @live -%>,
'language' => '<%= @language -%>',
'enable_advanced_correlations' => <%= @enable_advanced_correlations -%>,
<% unless @python_bin.nil? -%> 'python_bin' => '<%= @python_bin -%>',<%= "\n" %><% end -%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a unit test to ensure this works?

@vox-pupuli-tasks
Copy link

Dear @liviuvalsan, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @liviuvalsan, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @liviuvalsan, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @liviuvalsan, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants