Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB 4.2.10 starts to emit warnings about slaveOk() being deprecated, which breaks the module #596

Closed
dhs-rec opened this issue Oct 7, 2020 · 14 comments · Fixed by #594

Comments

@dhs-rec
Copy link
Contributor

dhs-rec commented Oct 7, 2020

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.18.0
  • Distribution: Debian Buster
  • Module version: 3.1.0

How to reproduce (e.g Puppet code you use)

Increase MongoDB version from 4.2.9 to 4.2.10.

What are you seeing

Puppet agent runs start failing with an error:

Info: Applying configuration version '1602075392'
Error: Could not prefetch mongodb_database provider 'mongodb': 765: unexpected token at 'WARNING: ) is deprecated and may be removed in the next major release. Please use secondaryOk( instead.

Unfortunately, Puppet cuts off some bits of the message, but I assume the real warning is this:

slaveOk() is deprecated and may be removed in the next major release. Please use secondaryOk() instead.

And indeed, if I change all occurrences of slaveOk() to secondaryOk() it starts working again.

What behaviour did you expect instead

A simple warning shouldn't break the module.

Output log

See above.

@ekohl ekohl linked a pull request Oct 7, 2020 that will close this issue
@ekohl
Copy link
Member

ekohl commented Oct 7, 2020

Fixed in #594

@ekohl ekohl closed this as completed Oct 7, 2020
@dhs-rec
Copy link
Contributor Author

dhs-rec commented Nov 10, 2020

Any chance this gets released any time soon?

@antondollmaier
Copy link

Any chance this gets released any time soon?

Same here.

Any chance that there might be a release? Is there something stopping a possible release?

@ekohl
Copy link
Member

ekohl commented Dec 22, 2020

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

@dhs-rec
Copy link
Contributor Author

dhs-rec commented Dec 26, 2020

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

That's really bad practice, isn't it? This should IMHO be a task for a maintainer of the project, not for the average user.

@ekohl
Copy link
Member

ekohl commented Dec 26, 2020

Voxpupuli is a collective. To quote voxpupuli.org:

We are a collective of Puppet module, tooling and documentation authors all working together to ensure continued development on the code we maintain.

However, it is volunteer driven. My past few months have been crazy busy so I had no time for it. However, anyone can join the project. We rely on users actually maintaining modules. I've always liked open source because it gave me the ability to fix my own problems. Here it's the same thing: you have a problem and there is a clear opportunity to fix your problem.

@antondollmaier
Copy link

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

I can live with this "policy" - I was under the impression that this needs to be done by a maintainer. Let's see ...

@pier4r
Copy link

pier4r commented Jan 4, 2021

Question: why is it closed?

I understand that we, as community, should fix the issue but the issue in itself is still open right? 3.1.0 has still the problem

(reproduced with puppet 4.10 and CentOS 7.9 . I think also puppet 5.5 has the same problem)

@ekohl
Copy link
Member

ekohl commented Jan 4, 2021

Issues are closed when it has been fixed in master.

@pier4r
Copy link

pier4r commented Jan 4, 2021

Ah ok so it is not yet released. Thank you!

@hdep
Copy link
Contributor

hdep commented Feb 9, 2021

Hi,

any change to get this fix released soon ? Last release of the module is 1 year old.
I need this fix because currently the module doesn't works anymore on our mongodb up-to-date nodes.

Thanks you !

@ekohl
Copy link
Member

ekohl commented Feb 9, 2021

I can only speak for myself, but we just merged the last patches to get rid of MongoDB completely in our infra. That means I no longer have an interest in this module. https://voxpupuli.org/docs/about_vox_pupuli/ isn't very clear on how to join, but I'd encourage anyone who depends on this module to step up and become a maintainer.

@pier4r
Copy link

pier4r commented Feb 14, 2021

So effectively this module is at the moment without a main maintainer?

@ekohl
Copy link
Member

ekohl commented Feb 14, 2021

Looking at who merged patches in the past time, I think it's fair to say that this module needs a maintainer. Vox Pupuli is designed as an organization that easily allows a new maintainer to step in though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants