Allow setting of net.ssl.mode #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for this feature, is anything else needed to have it merged? |
|
I'm using this on my test env without issues. |
|
I'll throw my 👍 for this feature. |
hypertext418
pushed a commit
to hypertext418/puppetlabs-mongodb
that referenced
this pull request
Apr 25, 2017
|
This needs a rebase now. |
update README with sslMode setting
|
rebased. |
ekohl
requested changes
Oct 2, 2017
README.md
Outdated
| @@ -505,7 +505,11 @@ Default: False | |||
| Set to true to disable fqdn SSL cert check | |||
| Default: False | |||
|
|
|||
| ##### `service_manage` | |||
| #####`ssl_mode` | |||
There was a problem hiding this comment.
Could you add a space? I believe this used to be allowed by GH markdown but they now follow CommonMark a bit stricter.
README.md
Outdated
| Ssl authorization mode. Valid options are: requireSSL, preferSSL, allowSSL. | ||
| Default: requireSSL | ||
|
|
||
| #####`service_manage` |
ekohl
approved these changes
Oct 2, 2017
juniorsysadmin
added
enhancement
juniorsysadmin
approved these changes
Jan 15, 2018
|
Hi @bond-os , this should probably have a matching test. Are you able to add one? |
|
Hi, I should be able to make one sometime this week. Something besides server_config_spec? |
|
Ok, so is there anything more needed to get this merged? |
|
Hi @bond-os, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting of net.ssl.mode option, as it cannot be set in set_parameter for startup and is hardcoded in confing.