Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-supplied configuration data #389

Merged
merged 6 commits into from
Oct 19, 2017
Merged

Conversation

blackophelia
Copy link

Added support to provide a hash containing user-supplied key/value pairs for use with configuration templates.

Support added for mongodb::server and mongodb::mongos classes.

README.md Outdated
@@ -426,6 +426,11 @@ Mutually exclusive with `replset_config` param.
A hash that is used to configure the replica set.
Mutually exclusive with `replset_members` param.

##### `config_data`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved below the replset example

@atward
Copy link
Contributor

atward commented Jul 31, 2017

Shouldn't the mongodb templates be extended to include the values of config_data? eg (for 2.6):

<% @config_data.each do |k,v| -%>
<%= k %>: <%= v %>
<% end -%>

@ekohl
Copy link
Member

ekohl commented Oct 2, 2017

This now has merge conflicts and needs a rebase.

@atward
Copy link
Contributor

atward commented Oct 13, 2017

@ekohl rebased against origin/master

@bastelfreak
Copy link
Member

Hi @atward, thanks for the rebase. @ekohl should we wait with merging this until #397 is done?

@wyardley wyardley merged commit 09ae0f6 into voxpupuli:master Oct 19, 2017
@wyardley wyardley added the enhancement New feature or request label Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants